[#726,#774] Migrate to pyproject.toml and add GH action for ruff#790
[#726,#774] Migrate to pyproject.toml and add GH action for ruff#790alanking merged 2 commits intoirods:mainfrom
pyproject.toml and add GH action for ruff#790Conversation
SwooshyCueb
changed the title
pyproject.toml and add GH action for ruff
|
Converting to draft, |
|
Ready for review. |
|
Looks like Ruff has an opinion |
It does. Given the teensy size of the file in question, I'm going to ignore this one. But it's a good example of what log output from ruff will look like, which @d-w-moore was asking about this morning. |
d-w-moore
left a comment
d-w-moore
left a comment
There was a problem hiding this comment.
Nice. I did cut and paste the unified diff and it worked via patch.
|
Let's go ahead and resolve the ruff-check. Get that free green. It can happen during the squash. If there's nothing else left to do, squash it. |
|
squashed |
|
Not sure if it was missed in the last time, or the GHA workflow picked up something new this time, but there's one more thing in the Ruff report. It could be instructive for future PRs to address it, and then we can get this in. |
|
Agreed. Let's remove the empty line it's reporting about and watch it turn green. |
|
Should be good now |
|
#'d |
5 participants
Addresses #726
Addresses #774